Adding transient storage maps with TLOAD/TSTORE implementation #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmacleal
force-pushed
the
fmacleal/adding_transient_storage_maps
branch
from
6142056
to
7149f88
Compare
fmacleal
force-pushed
the
fmacleal/addition_transient_storage_opcodes
branch
from
d6dc804
to
8892bf3
Compare
fmacleal
force-pushed
the
fmacleal/adding_transient_storage_maps
branch
3 times, most recently
from
743e9e8
to
3ce63a0
Compare
fmacleal
force-pushed
the
fmacleal/adding_transient_storage_maps
branch
from
c32eb3d
to
01c2a45
Compare
- Adding scratch from the DSL tests and contracts for tests - The tests are still failing, I am investigating to find the root cause - Adding more logic to the map structures - Finishing test validation for basic scenarios of TLOAD/TSTORE - Now we need to add more scenarios to validate that the memory isn't shared and erased in the end of the transaction.
- In order to get advantage from the whole flow of tracking, rollback and commits already present in the MutableRepository. We refactored a bit the logic of transient storage, now it's simpler. - The task isn't done yet, more tests needs to be added to validate that this is working properly.
fmacleal
force-pushed
the
fmacleal/adding_transient_storage_maps
branch
from
01c2a45
to
81cef20
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic implementation of the TLOAD/TSTORE opcodes with some DSL contracts tests. Still work in progress and more validations need to be added.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: